Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds removal notice to view.js.mustache #54105

Merged
merged 2 commits into from Sep 1, 2023
Merged

Adds removal notice to view.js.mustache #54105

merged 2 commits into from Sep 1, 2023

Conversation

mburridge
Copy link
Contributor

What?

Adds a line to view.js.mustache in the create-block package stating that it's safe to remove the file if no JavaScript is running in the front end.

Why?

Because the file is not needed if no JavaScript is going to run in the front end.

@mburridge mburridge added [Package] Create Block /packages/create-block Developer Experience Ideas about improving block and theme developer experience labels Sep 1, 2023
@mburridge mburridge added the [Type] Enhancement A suggestion for improvement. label Sep 1, 2023
gziolo
gziolo approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thank you for clarifying that since we don't want sites to load JS files that only log to the console 😄

@mburridge mburridge merged commit 959c9c1 into WordPress:trunk Sep 1, 2023
48 checks passed
@mburridge mburridge deleted the update/add-removal-notice-to-viewjs branch September 1, 2023 11:19
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 1, 2023
@bph bph added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Enhancement A suggestion for improvement. labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher ryanwelcher is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar

Assignees
No one assigned
Labels
Developer Experience Ideas about improving block and theme developer experience [Package] Create Block /packages/create-block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mburridge @gziolo @bph