New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 'nofollow' setting to Button block #54110

Merged

getdave merged 9 commits into WordPress:trunk from bangank36:add/nofollow-for-button-link

Sep 21, 2023

Contributor

bangank36 commented Sep 1, 2023 •

edited

What?

Add the ability to toggle the nofollow for Button's link.

Partial implementation of #54091
Prior art for Rich text link #53945

Why?

Check #53945 (comment)

How?

Place the nofollow option in the Advanced settings area
Update the linkValue for persisting the Advanced settings state

Testing Instructions

Open Post Editor
Add new Button block
Add a link to the Button
Click Edit link
Toggle the opensInNewTab and nofollow
Check and confirm whether the rel and target attributes has been inserted correctly

opensInNewWindow	nofollow	Generated
✅	❌	`target="_blank" rel="noreferrer noopener"`
❌	✅	`target="" rel="nofollow"`
✅	✅	`target="_blank" rel="noreferrer noopener nofollow"`
❌	❌	`target="" rel=""`

Testings

Verify and update these e2e tests
npm run test:e2e:playwright -- test/e2e/specs/editor/blocks/links.spec.js
npm run test:e2e:playwright -- test/e2e/specs/editor/blocks/buttons.spec.js
Insert new unit testing for updateLinkAttributes
npm run test:unit -- packages/block-library/src/button

Testing Instructions for Keyboard

Screenshots or screencast

Kapture.2023-09-01.at.19.39.59.mp4

bangank36 commented

View reviewed changes

packages/block-editor/src/components/link-control/index.js Outdated Show resolved Hide resolved

getdave added [Block] Buttons [Type] Feature [Feature] Link Editing labels

getdave assigned bangank36

bangank36 marked this pull request as ready for review

September 2, 2023 01:50

bangank36 requested review from kevin940726, Mamaduka, getdave and ajitbohra as code owners

September 2, 2023 01:50

bangank36 force-pushed the add/nofollow-for-button-link branch from f22ca0c to 3137c93 Compare

September 2, 2023 06:12

alexstine reviewed

View reviewed changes

Contributor

alexstine left a comment

One note below.

packages/block-editor/src/components/link-control/index.js Outdated Show resolved Hide resolved

bangank36 requested review from ellatrix, fluiddot and dcalhoun as code owners

September 4, 2023 16:10

getdave mentioned this pull request

Avoid <code> tags in No follow label of Link Control in Rich Text #54179

Closed

Contributor

scruffian commented Sep 7, 2023

This is looking good, just needs a rebase I think.

This comment was marked as outdated.

Sign in to view

getdave previously requested changes

View reviewed changes

Contributor

getdave left a comment •

edited

I'm going to block this PR because I"m not confident that we should be adding to the API of this component.

Let's discuss this further and get a wider range of opinions before we proceed.

Thank you 🙇

packages/block-editor/src/components/link-control/index.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

packages/format-library/src/link/inline.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

bangank36 force-pushed the add/nofollow-for-button-link branch from 8ae1504 to 08d44c6 Compare

September 8, 2023 02:58

bangank36 requested a review from getdave

September 8, 2023 02:59

getdave reviewed

View reviewed changes

packages/block-editor/src/components/link-control/index.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

packages/block-editor/src/components/link-control/index.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

bangank36 requested a review from getdave

September 13, 2023 00:01

getdave reviewed

View reviewed changes

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

test/e2e/specs/editor/blocks/buttons.spec.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

test/e2e/specs/editor/blocks/buttons.spec.js Outdated Show resolved Hide resolved

getdave reviewed

View reviewed changes

test/e2e/specs/editor/blocks/buttons.spec.js Outdated Show resolved Hide resolved

bangank36 force-pushed the add/nofollow-for-button-link branch from 2626796 to dbe9b5f Compare

September 14, 2023 03:38

bangank36 requested review from getdave and scruffian

September 14, 2023 03:39

Contributor Author

bangank36 commented Sep 20, 2023

Hi @getdave, just a friendly nudge to request your review of the latest changes on my PR when you have a moment. Thanks!

getdave reviewed

View reviewed changes

packages/block-library/src/button/edit.js Show resolved Hide resolved

getdave reviewed

View reviewed changes

Contributor

getdave left a comment

This is very close. Thank you for your patience.

I think upon reflection some unit tests would help add confidence here. They will also lay a solid foundation for a later refactoring.

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

bangank36 added 7 commits

September 21, 2023 10:56


          Render nofollow setting on Button Link editor

079d4ad


          Persist nofollow prop in LinkControl

c18ae5a

Use constant instead of string

Update e2e test for Button nofollow link setting

Improve settings toggle logic

- Update nofollow control label

Update link control label


          Remove nofollow settings from LinkControl

dc4d77d


          Refactor e2e testing

b71561c


          Add comment for rel handling

443046b


          Add unit tests

797ea44


          Add unit test for the UpdateLinkAttribute

7895ebd

bangank36 force-pushed the add/nofollow-for-button-link branch from 6df0f71 to 7895ebd Compare

September 21, 2023 03:56


          Missing eof

c588a77

bangank36 requested a review from getdave

September 21, 2023 04:07

getdave reviewed

View reviewed changes

Contributor

getdave left a comment

Great work here. A few more tweaks and we should be in a good place.

packages/block-library/src/button/utils.js Outdated Show resolved Hide resolved

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved

packages/block-library/src/button/edit.js Outdated Show resolved Hide resolved


          Update function path

f6e49a7

bangank36 requested a review from getdave

September 21, 2023 09:26

getdave reviewed

View reviewed changes

packages/block-library/src/button/edit.js Show resolved Hide resolved

getdave dismissed their stale review

September 21, 2023 10:36

Stale

getdave approved these changes

View reviewed changes

Contributor

getdave left a comment

Thank you for all the work on this.

LGTM 🚀

Contributor

getdave commented Sep 21, 2023

Note to WP 6.4 leads. I don't believe we need to backport this PR. Happy to be advised otherwise if folks find it to be sufficiently "blessed".

getdave merged commit 191fd0f into WordPress:trunk

49 checks passed

github-actions bot added this to the Gutenberg 16.8 milestone

bangank36 mentioned this pull request

Add nofollow to Link UI in Nav and Buttons blocks #54091

Open

This was referenced Sep 25, 2023

Migrate remaining Link UI tests to Playwright #52828

Merged

[WIP] Provide standardised tools for mapping Data to Link attributes #54791

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

getdave getdave approved these changes

alexstine alexstine left review comments

kevin940726 Awaiting requested review from kevin940726

Mamaduka Awaiting requested review from Mamaduka

ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

ellatrix Awaiting requested review from ellatrix

fluiddot Awaiting requested review from fluiddot

dcalhoun Awaiting requested review from dcalhoun

scruffian Awaiting requested review from scruffian