New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: Fix first block locator's page reference #54188
Conversation
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
This fixes the intermittent failure where the canvas locator times out after the default 10 seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down. This looks good to me.
What?
Bug: Current page for locating the first block is the one in the background (
page
), not the one that is subject to the test (testPage
). This might have been the reason for the recently unstable loading metrics.This PR fixes that + makes the Site Editor Loading test consistent with the Post Editor one + increases the timeout value for the canvas locator which fixes its recent flakiness (e.g. this job).