Background Image block support: Add reset menu item #54341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
|
Size Change: +26 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2e4f293. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6142755752
|
|
@andrewserong how would this reset action interact with a background image inherited from global styles? If it is effectively applying |
apeatling
reviewed
Sep 11, 2023
|
Thanks for taking a look, folks!
This PR just clears out the local background-image (if set), without outputting any styles. If and when we introduce background images in global styles, hitting Reset on a local-to-the-block background image will clear out the local image while allowing the global styles image (when we eventually add that behaviour) to be revealed. So, for the scope of this PR, there is no |
richtabor
deleted the
update/background-image-block-support-add-reset-button
branch
|
Thanks folks! 🙇 |
45 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #54319
Add a
Resetmenu item to the background image block support's replace media control.Why?
As raised in #54319 while the background image can be reset by the tools panel's dropdown menu, since the replace button displays a list of options, it'd be good for it to include
Resethere, too, for discoverability.How?
Add a
MenuItemto the use ofMediaReplaceFlowto render aResetbutton that clears out the background image.Testing Instructions
Testing Instructions for Keyboard
As above, but you should be able to tab over to the image button in the block inspector, press Enter, and then use arrow keys to reach the Reset button and then press Enter to clear the background image.
Screenshots or screencast
Screengrab:
2023-09-11.16.07.23.mp4