Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dialogdescription for renaming group block #54358

Merged
merged 1 commit into from Sep 12, 2023

Conversation

masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Sep 11, 2023

Fixes #54346

What?

@t-hamano made a good point i also noticed while testing. we should precise the popup message for the renaming introduced in #53735

Why?

Be more precise. there is nothing to be choosen you have to enter the text as you want :)

How?

Changing the text inserted in code.

Testing Instructions

  1. New Post (or enter the Site Editor)
  2. Add some blocks and then Group them.
  3. Open List View
  4. Now open the block options menu (either via List View or via the block in the canvas) and click Rename.
  5. Check message above field

Testing Instructions for Keyboard

Screenshots or screencast

@t-hamano t-hamano added Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance [Block] Group Affects the Group Block labels Sep 11, 2023
@t-hamano t-hamano self-requested a review September 11, 2023 16:22
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @masteradhoc!

I think this change makes sense, but would like to hear from @getdave, @richtabor, @andrewserong who were involved in #53735 🙏

Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this approve as it is more clear in English. Interested to hear other opinions.

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you.

@t-hamano
Copy link
Contributor

Thank you everyone, now let's merge this PR.

@masteradhoc Thank you for your contribution!

@t-hamano t-hamano merged commit 94aad94 into WordPress:trunk Sep 12, 2023
56 of 57 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 12, 2023
@masteradhoc masteradhoc deleted the patch-1 branch September 12, 2023 06:20
@mikachan mikachan added [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement. and removed Needs Design Feedback Needs general design feedback. [Type] Copy Issues or PRs that need copy editing assistance labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Block: Update the text in the rename modal to the appropriate one
5 participants