Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Undocument the focus prop #54397

Merged
merged 6 commits into from Sep 13, 2023
Merged

Button: Undocument the focus prop #54397

merged 6 commits into from Sep 13, 2023

Conversation

chad1008
Copy link
Contributor

fixes #50972

What?

Wrapping up the work started in #51808, a new PR was easier to wrangle with the previous PR being generated from a fork. This PR removes the focus prop from the Button component's documentation.

Why?

This prop is no longer active on the component (see the above issue for more details) and shouldn't be listed in the docs.

How?

I used the delete button 馃槈

Testing Instructions

Check the Button component's README and types files, confirm the focus prop is no longer listed.

@chad1008 chad1008 self-assigned this Sep 12, 2023
@chad1008 chad1008 added [Package] Components /packages/components [Type] Developer Documentation Documentation for developers labels Sep 12, 2023
@chad1008 chad1008 mentioned this pull request Sep 12, 2023
Closed
alexstine
alexstine approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 馃憤

tyxla
tyxla approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤 馃殌

Thanks, @noahbcaldwell and @chad1008!

Left an optional question and a minor suggestion, but looks great otherwise!

packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
chad1008 and others added 2 commits September 13, 2023 13:27
@chad1008 @tyxla
Update changelog entry
4eaa83c 
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
@chad1008
move changelog entry to "internal"
6256800
@chad1008
Copy link
Contributor Author

Thank you both! Waiting on the last CI checks and merging 馃憤

@chad1008 chad1008 enabled auto-merge (squash) September 13, 2023 17:32
@chad1008 chad1008 merged commit 2f7afe3 into trunk Sep 13, 2023
50 checks passed
@chad1008 chad1008 deleted the update-button-focus-prop branch September 13, 2023 18:05
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@alexstine alexstine alexstine approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ciampo ciampo Awaiting requested review from ciampo

@brookewp brookewp Awaiting requested review from brookewp

Assignees

@chad1008 chad1008

Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.

Button: Undocument the focus prop
4 participants
@chad1008 @tyxla @alexstine @noahbcaldwell