Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrapped ref in quotes in theme.json docs #54591

Merged
merged 1 commit into from Sep 19, 2023

Conversation

Piyush-Deshmukh
Copy link
Contributor

What?

In how-to-guide theme.json, wrapped ref in Quotes

Why?

Closes #54537

How?

{
    "color": {
        "text": { "ref": "styles.color.background" }
    }
}

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Piyush-Deshmukh! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 19, 2023
@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Sep 19, 2023
@t-hamano t-hamano self-requested a review September 19, 2023 12:30
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the PR!

@t-hamano t-hamano merged commit 83d76e1 into WordPress:trunk Sep 19, 2023
50 of 55 checks passed
@github-actions
Copy link

Congratulations on your first merged pull request, @Piyush-Deshmukh! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 19, 2023
@jeffpaul
Copy link
Member

@Piyush-Deshmukh we're working on collecting folks to credit in the WordPress 6.4 release, but do not yet have your WordPress.org username to include. Would you mind confirming that here and/or adding your GitHub handle to your WordPress.org account as noted in the comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Global Settings & Styles (theme.json) ref needs to be wrapped in quotes
3 participants