Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global styles tests: fire hooks when updating post #54836

Merged
merged 1 commit into from Sep 26, 2023
Merged

Global styles tests: fire hooks when updating post #54836

merged 1 commit into from Sep 26, 2023

Conversation

Mamaduka
Copy link
Member

What?

Cherry-picks changes from #52988 (comment) to fix failing PHPUnit tests on trunk.

Testing Instructions

CI should be green.

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Sep 26, 2023
@Mamaduka Mamaduka self-assigned this Sep 26, 2023
@github-actions
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ phpunit/class-gutenberg-rest-global-styles-revisions-controller-test.php

@hellofromtonya hellofromtonya enabled auto-merge (squash) September 26, 2023 17:55
@hellofromtonya
Copy link
Contributor

Set to auto-merge once the CI jobs pass.

@github-actions
Copy link

Flaky tests detected in 7c81717.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6316427368
📝 Reported issues:

@hellofromtonya hellofromtonya merged commit 9a34f30 into trunk Sep 26, 2023
53 checks passed
@hellofromtonya hellofromtonya deleted the fix/global-style-revisions-unit-tests branch September 26, 2023 18:24
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 26, 2023
@mikachan mikachan added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) labels Sep 27, 2023
@mikachan mikachan removed the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Sep 27, 2023
@mikachan
Copy link
Member

I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: d76e018

mikachan pushed a commit that referenced this pull request Sep 27, 2023
@Mamaduka @adamsilverstein @mikachan
Global styles tests: fire hooks when updating post (#54836)
d76e018 
Co-authored-by: Adam Silverstein <adamjs@google.com>
@mikachan mikachan removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Sep 27, 2023
@getdave getdave mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellofromtonya hellofromtonya hellofromtonya approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

@Mamaduka Mamaduka

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mamaduka @hellofromtonya @mikachan @adamsilverstein