New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a documentation page about the block editor settings #54870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs are looking great, nice work 👍
I spotted a couple of typos so have left inline comments for those and some other minor tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left some predictably pedantic suggestions.
"Whether or not" is interesting though - it's mostly used when the outcome is not important. Like, "Whether or not Github allows threads in comments, I'm still going to use it!"
Related #53874
What?
Just documents some of the most important settings a user can pass as a prop to the
BlockEditorProvider
component. I think we're still missing the "theme.json" settings and styles from this list but these should be added when we decided on a stable name.Test the documentation website