Patterns: Add duplicate pattern command #55292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +362 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
aaronrobertshaw
changed the base branch from
trunk
to
try/rename-pattern-command
aaronrobertshaw
force-pushed
the
add/duplicate-pattern-command
branch
from
3b1e990
to
e4eda2d
Compare
aaronrobertshaw
changed the title
This was referenced Oct 12, 2023
glendaviesnz
approved these changes
Oct 12, 2023
kevin940726
approved these changes
Oct 12, 2023
|
Thanks for the reviews!
Commands for templates and template parts were going to be a follow-up. I noted that in #55188 which this PR originally depended on but missed adding it to the PR description here. I'll get this merged and begin follow-up on template parts shortly. Edit: I've added a note to the PR description about template parts being out of scope here. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Extracts pattern duplication modal into the patterns package and adds a new duplicate pattern command for the site editor.
Note: Commands for templates and template parts will be considered separate follow-ups
Why?
Makes it easier for users to work around the fact they cannot change a pattern's sync status.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-10-12.at.5.23.30.pm.mp4