New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data: Fix combineReducers()
types
#55321
Conversation
Size Change: +2 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
Flaky tests detected in a9c4fe0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6498794631
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared the build types on trunk vs this branch, and this definitely fixes the issue! Thanks :) I'll research how to release this to npm.
Am now following the process documented here: https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/release.md#standalone-bugfix-package-releases |
What?
This PR fixes the built types of the
combineReducers
utility that we export from@wordpress/data
.Why?
In #54606 we broke the types of
combineReducers
because the inline JSDoc type definition for thecombineReducers
export no longer worked with the newexport { module }
syntax.This bug was reported in #54606 (comment)
How?
We're using the
export const
syntax and that resolves the inline JSDoc type so it properly picks it up as it did before.Testing Instructions
@wodpress/data
package and verify that thecombineReducers
type properly uses the type definition from the package's types.Testing Instructions for Keyboard
None
Screenshots or screencast
None