Navigation block: Fix Inaccurate description of the Show icon button setting

[masteradhoc]

What?

Goal is to adjust the description of the "Show icon button" setting to be more precise.

Fixes #55163

Why?

How?

Make the description more accurate so its clear for users what to expect.

Testing Instructions

1. Go to the site editor
2. Add a Navigation block if there is none yet.
3. Select the Navigation and observe the settings panel.
4. Observe the "Show icon button' setting visually shows both the opening and closing buttons.
5. Observe it description only mentions both the opening and closing button.

Testing Instructions for Keyboard

Screenshots or screencast

[alexstine]

👍

[alexstine]

CC @getdave so you are aware.

[getdave]

Thanks for the PR (and the ping). Left a small suggestion.

[masteradhoc]

@getdave no problem at all. Committed. Ready for you :)

[masteradhoc]

@getdave can this be merged? :)

[afercia]

Just a quick reminder that there is a long pending issue on Trac, also reported here on GitHub, that the verb 'toggle' should be avoided as it's hard if not impossible to translate to other languages. See:
https://core.trac.wordpress.org/ticket/34753
#42492

[getdave]

Just a quick reminder that there is a long pending issue on Trac, also reported here on GitHub, that the verb 'toggle' should be avoided as it's hard if not impossible to translate to other languages. See: https://core.trac.wordpress.org/ticket/34753 #42492

I was not aware of that. Thank you for making us aware.

What would be preferable? Or is it case-by-case?

[getdave]

Configure the visual appearance of the button that toggles the overlay menu.

Should this instead be

"Configure the visual appearance of the button that shows/hides the overlay menu."?

[afercia]

What would be preferable?

I'm not sure there has been agreement on establishing a new pattern. I'd be in favour of fixing all occurences holistically in core and the editor once a pattern has been established. For now, let's try to avoid to introduce new occurrences please and share with other the oncoing discussion.