TextControl: Add opt-in prop for 40px default size
#55471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
|
Size Change: +209 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c806c4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6777428725
|
brookewp
force-pushed
the
add/40px-size-text-control
branch
from
71c3911
to
642be60
Compare
ciampo
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Left a couple of comments, but this is looking good!
cc'ing @jameskoster and @richtabor
packages/editor/src/components/post-publish-panel/test/__snapshots__/index.js.snap
Outdated
Show resolved
Hide resolved
|
Nice. Should we also update that 29px default height to 32px here (related: #55490)? |
brookewp
force-pushed
the
add/40px-size-text-control
branch
from
642be60
to
a5d3433
Compare
From the PR you mentioned:
With the above context, I assume a 3px change is also okay to proceed with? |
Hey @jameskoster , to make sure we're on the same page here: in this PR we are working towards transitioning |
|
Hm, thinking beyond the Editor, forcing 40px in all situations might be a bit heavy-handed? It's fine as a default, but there could be scenarios that call for a smaller control. cc @jasmussen @SaxonF @richtabor for more thoughts on that. |
|
The idea is 40px is the default, but the compact 32px can be used on a per-basis case. 40px is the tall and graceful, neatly clickable on big screens and phones, default. I'd turn the question around, why would you want a 32px default? |
Unless I'm mistaken I think the question was about whether 32px is needed at all, not whether it's the default. |
|
32 feels useful across buttons and text controls both, as they might appear next to each others, IMO. |
This sounds sensible. However, since I don't remember this being included in the initial specs, it may be beneficial to understand what other components we may need to render at a We can keep this PR as-is (focused on starting the transition to |
|
I'd imagine any control that we're making 40px could also use a 32px size variant. |
Even more so, then, let's discuss this holistically so that we can have as much of a coherent approach as possible, since this feels like a departure from the specs shared here, where For this PR, I think it's fine to update the current default size from 29 to 32px, knowing that it will be eventually become 40px. |
brookewp
force-pushed
the
add/40px-size-text-control
branch
from
823aad2
to
c93b3de
Compare
brookewp
force-pushed
the
add/40px-size-text-control
branch
from
c93b3de
to
5c806c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
Add a new opt-in prop
__next40pxDefaultSizeto TextControl, following the plan outlined in above mentioned PR.Why?
For more consistency in styling.
How?
A new, temporary
__next40pxDefaultSizeprop. When the prop is set totrue, the input will have a height of 40px instead of 29px.Testing Instructions
In Storybook:
npm run storybook:dev__next40pxDefaultSizeset tofalse__next40pxDefaultSizetotrueIn the editor
Smoke test the component in the editor; TextControl shouldn't have any visible changes for now.