New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: add filters to table columns #55508
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6415dd7
View config: filters declare their type
oandregal 5db8bce
Fix rebase
oandregal e4d831d
Bootstrap filters in columns
oandregal 4b6d337
Process as many filters as the field declared
oandregal 8ce0896
Add not in filter for author
oandregal e2b28e1
Limit filter generation to enumeration filters for now
oandregal 41b3faa
filter.type: add more granularity for IN/NOT IN filters
oandregal 73f7e10
Enumeration filter uses filter.name and filter.type to render the prefix
oandregal a2ea3c8
Limit column filters to only one: enumeration
oandregal 56f28ce
Use TanStack column filters
oandregal 0ba1f03
Remove unused filter property
oandregal 23bed43
Fix for author filter
oandregal 9d27b8a
Remove unnecessary property
oandregal 9bf7de7
Remove comment
oandregal fddcc43
Improve comment
oandregal 4602eed
Simplify
oandregal 5648584
Add new funnel icon
oandregal 654f0f7
Use funnel icon
oandregal 8f812dd
Remove reset prop for filters
oandregal a9c651b
Reset pagination upon column filter being selected
oandregal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { SVG, Path } from '@wordpress/primitives'; | ||
|
||
const funnel = ( | ||
<SVG viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"> | ||
<Path d="M10 17.5H14V16H10V17.5ZM6 6V7.5H18V6H6ZM8 12.5H16V11H8V12.5Z" /> | ||
</SVG> | ||
); | ||
|
||
export default funnel; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small non blocking remark: This component
HeaderMenu
is built as a tan stack component (gets dataView and header) and renders a dropdown. I wonder if it could be similar to built it as a DataView component instead. (get the view and field as props).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought #55508 (comment)