Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: add filters to table columns #55508

Merged
merged 20 commits into from Nov 7, 2023
Merged

DataViews: add filters to table columns #55508

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6415dd7
View config: filters declare their type
oandregal Oct 31, 2023
5db8bce
Fix rebase
oandregal Nov 2, 2023
e4d831d
Bootstrap filters in columns
oandregal Oct 20, 2023
4b6d337
Process as many filters as the field declared
oandregal Oct 20, 2023
8ce0896
Add not in filter for author
oandregal Oct 20, 2023
e2b28e1
Limit filter generation to enumeration filters for now
oandregal Oct 20, 2023
41b3faa
filter.type: add more granularity for IN/NOT IN filters
oandregal Oct 20, 2023
73f7e10
Enumeration filter uses filter.name and filter.type to render the prefix
oandregal Oct 20, 2023
a2ea3c8
Limit column filters to only one: enumeration
oandregal Oct 20, 2023
56f28ce
Use TanStack column filters
oandregal Nov 2, 2023
0ba1f03
Remove unused filter property
oandregal Nov 2, 2023
23bed43
Fix for author filter
oandregal Nov 2, 2023
9d27b8a
Remove unnecessary property
oandregal Nov 2, 2023
9bf7de7
Remove comment
oandregal Nov 2, 2023
fddcc43
Improve comment
oandregal Nov 2, 2023
4602eed
Simplify
oandregal Nov 2, 2023
5648584
Add new funnel icon
oandregal Nov 2, 2023
654f0f7
Use funnel icon
oandregal Nov 2, 2023
8f812dd
Remove reset prop for filters
oandregal Nov 3, 2023
a9c651b
Reset pagination upon column filter being selected
oandregal Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/edit-site/src/components/dataviews/view-list.js
View file
Open in desktop
Expand Up @@ -427,12 +427,13 @@ function ViewList( {
} );
},
onGlobalFilterChange: ( value ) => {
onChangeView( { ...view, search: value, page: 0 } );
onChangeView( { ...view, search: value, page: 1 } );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, this value is not being used – or is ignored once the own Search component updates it to 1 here. I thought I'd change it anyway, though this needs a separate further investigation.

},
onColumnFiltersChange: ( columnFiltersUpdater ) => {
onChangeView( {
...view,
filters: fromTanStackColumnFilters( columnFiltersUpdater() ),
page: 1,
} );
},
onPaginationChange: ( paginationUpdater ) => {
Expand Down