Social link: Trim rel attribute to avoid needless space.
#55705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky tests detected in c805b3530996dcd8908a2956234f3dab729a59d5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6695150296
|
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Resolves Core-59682 When generating the `rel` attribute on social links, adds a `trim()` call for aesthetic reasons and also to prevent third-party code from breaking, when looking for `rel="noopener"`. Also removes a superfluous call to `esc_attr()` since the Tag Processor already escapes its attribute values.
dmsnell
force-pushed
the
social-link/trim-rel-attribute
branch
from
c805b35
to
929a37d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Core-59682
When generating the
relattribute on social links, adds atrim()call for aesthetic reasons and also to prevent third-party code from breaking, when looking forrel="noopener".Also removes a superfluous call to
esc_attr()since the Tag Processor already escapes its attribute values.What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast