DataViews: update filters in view config #55735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
youknowriad,
ntsekouras,
jorgefilipecosta and
mcsf
oandregal
added
the
[Feature] Data Views
|
Size Change: +102 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Nov 1, 2023
youknowriad
reviewed
Nov 1, 2023
| author: 2, | ||
| status: 'publish, draft' | ||
| author: { in: 2 }, | ||
| status: { in: 'publish, draft' } |
There was a problem hiding this comment.
I feel a better representation of the filter is something like { operator: 'in', values: 2 } because in a lot of cases you should be able to switch the operator without switching the values.
There was a problem hiding this comment.
I think we need to support multiple operators per field and being ready for logical operators and/or (hierarchicial filters). This is how it looks like in the current approach:
{
filters: {
or: {
date: { before: "20231001", after: "20230101" }, // date published
modified: { before: "20231001", after: "20230101" }, // date modified
}
}
}It's inspired by linear. It sounds easy enough to do anything we want, even switching values/operators.
There was a problem hiding this comment.
I actually prefer something like
filters: {
operator: 'or',
children: [
{ 'field': 'author', operator: 'startsWith', value: "something" ],
{ 'field': 'author', operator: 'contain', value: "ok" ],
{ 'field2': 'author', operator: 'in', values: ["blabla" ] },
]
}
There was a problem hiding this comment.
which could also support this:
filters: {
operator: 'or',
children: [
{ 'field': 'author', operator: 'startsWith', value: "something" ],
{ 'field': 'author', operator: 'contain', value: "ok" ],
{ 'field2': 'author', operator: 'in', values: ["blabla" ] },
{ operator: 'and', children: [
{ 'field': 'status', operator: 'in', values: [ 'draft', 'publish' ] }
] }
]
}
There was a problem hiding this comment.
Do you feel strongly about that filters shape? I don't see it being easier to work with for changing operators or anything else (update the value of an existing filter). It's also a lot more verbose. Example:
{
filters: [
{ field: 'author', operator: 'in', value: 2 },
{ field: 'status', operator: 'in', value: 'draft' }
]
}vs
{
filters: {
author: { in: 'draft' },
status: { in: 2 }
}
}There was a problem hiding this comment.
I don't feel strongly but I think it's actually easier to work with compared to what you propose:
- A filter object is self sufficient, it contains all the information it needs (the field id, the operator and the values), it's not on multiple levels.
- Filter objets can be combined.
So basically you can pass a filter object to a component and renders it entirely.
In your proposal, it's not clear to me, how you handle: multiple operators for the same field and nested logical operators. Can you translate the example I have here in your format to get more clarity #55735 (comment) ?
There was a problem hiding this comment.
In your proposal, it's not clear to me, how you handle: multiple operators for the same field and nested logical operators. Can you translate the example I have here in your format to get more clarity #55735 (comment) ?
I already did right at the beginning of this thread and in the PR description :)
I went ahead and implemented your proposal at 379fae1 Also updated the PR description with the new shape.
There was a problem hiding this comment.
I already did right at the beginning of this thread and in the PR description :)
I see the multiple operators but not the "and" nested within the "or"
oandregal
force-pushed
the
update/filters-in-view-config
branch
from
a97ba29
to
c813994
Compare
oandregal
force-pushed
the
update/filters-in-view-config
branch
from
9d92ffc
to
d0a33fb
Compare
|
Is anything left to address here? Can it be merged? I'm working on some related PRs and would be beneficial to merge this one, so I can publish the others based on |
youknowriad
approved these changes
Nov 2, 2023
oandregal
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
This PR updates how filters are stored in the view config.
Before:
After:
Why?
This provides a general syntax that consumers can use to query their datasets.
Testing Instructions
You may need to clear any previously stored dataview entity/CPT. One way to do it is to set
show_uitotrueindataviews.phpso they are listed in wp-admin. Then, delete it.