Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Changes imports from wp.editor to wp.blockEditor for PlainText and RichText #55841

Merged
merged 1 commit into from Nov 3, 2023
Merged

Docs: Changes imports from wp.editor to wp.blockEditor for PlainText and RichText #55841

merged 1 commit into from Nov 3, 2023

Conversation

Soean
Copy link
Member

@Soean Soean commented Nov 3, 2023

What?

The components PlainTextand RichText are from the block-editor, not from the editor package.
This PR fixes the code examples in the readme.

Fixes #55831

@Soean Soean added [Type] Developer Documentation Documentation for developers [Package] Block editor /packages/block-editor labels Nov 3, 2023
@Soean Soean self-assigned this Nov 3, 2023
Mamaduka
Mamaduka approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Soean!

@Soean Soean merged commit 24bf989 into trunk Nov 3, 2023
55 checks passed
@Soean Soean deleted the 55831 branch November 3, 2023 12:33
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 3, 2023
@waviaei waviaei mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@fluiddot fluiddot Awaiting requested review from fluiddot fluiddot is a code owner

@dcalhoun dcalhoun Awaiting requested review from dcalhoun dcalhoun is a code owner

Assignees

@Soean Soean

Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 17.1
Development

Successfully merging this pull request may close these issues.

Wrong imports in RichText docs
2 participants
@Soean @Mamaduka