Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Detach" text change in template options #55870

Merged
merged 1 commit into from Nov 8, 2023
Merged

"Detach" text change in template options #55870

merged 1 commit into from Nov 8, 2023

Conversation

JorgeVilchez95
Copy link
Contributor

@JorgeVilchez95 JorgeVilchez95 commented Nov 5, 2023 •
edited by cbravobernal

Fixes #55601
Change in the text of the template options, previously "Detach blocks from template part" appeared, now "Detach" appears.

Made with love from WordCamp Madrid 2023 - Contributor Day

Captura de pantalla 2023-11-05 131157

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @JorgeVilchez95! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 5, 2023
@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label Nov 6, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Nov 6, 2023

Thank you, @JorgeVilchez95! Is there a corresponding issue for this PR where this change has been requested or discussed?

@cbravobernal
Copy link
Contributor

Thank you, @JorgeVilchez95! Is there a corresponding issue for this PR where this change has been requested or discussed?

Yes! I updated the the PR description with it.

Mamaduka
Mamaduka approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for contributing, @JorgeVilchez95!

I've restarted failing e2e tests, which don't look related.

@cbravobernal cbravobernal merged commit 9ca6c8f into WordPress:trunk Nov 8, 2023
52 of 54 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 8, 2023
@cbravobernal cbravobernal added the [Package] Editor /packages/editor label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@kevin940726 kevin940726 Awaiting requested review from kevin940726

@jameskoster jameskoster Awaiting requested review from jameskoster

@richtabor richtabor Awaiting requested review from richtabor

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 17.1
Development

Successfully merging this pull request may close these issues.

Reduce complexity of detach control in template parts
3 participants
@JorgeVilchez95 @Mamaduka @cbravobernal