Core Data: Move the template lookup to core-data selectors/resolvers #55883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
added
[Type] Code Quality
youknowriad
commented
Nov 6, 2023
| : undefined; | ||
| }, | ||
| [ slug, isCustom ] | ||
| ); | ||
| } |
There was a problem hiding this comment.
@jorgefilipecosta can you help me test the start templates please.
There was a problem hiding this comment.
I tested that by creating a new template and verifying the proper fallback template is suggested in the modal. Alternatively you 'empty' a template completely, save and reload, in order for the modal to show up. It seems it's working fine.
|
Size Change: +1.22 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Nov 7, 2023
ntsekouras
approved these changes
Nov 7, 2023
| ( query ) => | ||
| async ( { dispatch } ) => { | ||
| const template = await apiFetch( { | ||
| path: addQueryArgs( '/wp/v2/templates/lookup', query ), |
There was a problem hiding this comment.
I've discovered a different issue here while testing. If the current default template is empty the REST endpoint returns the next one available from template hierarchy. That's an issue, because front end and the editor show different things. I'll create an issue for this.
|
Flaky tests detected in 15f0adc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6782750343
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #55844
This PR adds
getDefaultTemplateIdselectors to core-data to avoid the adhoc apiFetch calls. The main reason I'm doing this PR is because I want to deprecate thesetPageaction in the site editor because it does too much and replace it with a React hook like done in #55844Testing Instructions
1- Test navigation between different sections of the site editor (pages, single pages...)
2- Test starter templates.