Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label enforcer: make the warning message less scary for new contributors #55900

Merged

Conversation

priethor
Copy link
Contributor

@priethor priethor commented Nov 6, 2023

What?

Tries to make the warning message for PRs without the right type-related label less scary.

Why?

New contributors who don't have the right permissions to add labels can make the onboarding experience a bit confusing or scary.

How?

Changing the warning message to address the fact that they might not have enough permissions, but the PR reviewer should be able to help, and removing the word error in the header of the message.

@priethor priethor added the [Type] Project Management Meta-issues related to project management of Gutenberg label Nov 6, 2023
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the clarification!
Some new contributors reached me worried about that warning, believing it was their fault :-)

#55702 (comment)

@priethor priethor merged commit 25ce128 into trunk Nov 7, 2023
52 checks passed
@priethor priethor deleted the update/make-pr-label-enforcer-less-scary-to-new-contributors branch November 7, 2023 16:26
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants