New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataviews: Add a missing icon for the side by side view. #55925
Conversation
Size Change: +55 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
@@ -13,7 +13,7 @@ import { unlock } from '../../lock-unlock'; | |||
const { useLocation } = unlock( routerPrivateApis ); | |||
|
|||
function getDataViewIcon( type ) { | |||
const icons = { list: page, grid: columns }; | |||
const icons = { list: page, grid: columns, 'side-by-side': mediaAndText }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about what icon to use. Design may want to offer some thoughts, but it's good to start with something – so I'm preapproving.
fda6e88
to
491dbab
Compare
Thank you for the review @oandregal I updated to pullRight icon as it seemed a better fit 👍 |
Adds a missing icon to the side-by-side view.
Screenshots
After:
Before: