DropdownMenuV2: use the Icon component to render radio checks
#55964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
youknowriad
reviewed
Nov 8, 2023
| <SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> | ||
| <Circle cx={ 12 } cy={ 12 } r={ 3 }></Circle> | ||
| </SVG> | ||
| ); |
There was a problem hiding this comment.
Do we want to make that one an official icon in our icon library maybe? cc @jasmussen
youknowriad
approved these changes
Nov 8, 2023
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
* DropdownMenuV2: use the `Icon` component to render radio checks * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the way the experimental version of
DropdownMenurenders the radio check iconWhy?
Currently, the icon is not displayed correctly across all browsers (including MacOS Safari)
How?
By refactoring the code to use the
Iconcomponent to display the icon:DropdownMenu, since theIconcomponent is used internally to render the checkbox item's checkIconcomponent sets an explicit size for the underlying SVG elementTesting Instructions
trunk, the radio icon doesn't showScreenshots or screencast