Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates: Update filter to call all of the individual methods #55980

Merged
merged 3 commits into from Nov 9, 2023
Merged

Templates: Update filter to call all of the individual methods #55980

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4afac6c
Update filter to call all of the individual methods, currently only t…
glendaviesnz Nov 8, 2023
da8b04f
remove filter duplicates by name method as duplicates are removed on …
glendaviesnz Nov 8, 2023
83f54c5
Revert "remove filter duplicates by name method as duplicates are rem…
glendaviesnz Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/edit-site/src/components/sidebar-edit-mode/template-panel/hooks.js
View file
Open in desktop
Expand Up @@ -51,9 +51,10 @@ function preparePatterns( patterns, template, currentThemeStylesheet ) {

return patterns
.filter(
filterOutExcludedPatternSources &&
filterOutDuplicatesByName &&
filterCompatiblePatterns
( pattern, index, items ) =>
filterOutExcludedPatternSources( pattern ) &&
filterOutDuplicatesByName( pattern, index, items ) &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think any duplicates by name will be removed here, so I wonder if we need this filter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't then :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might warrant a deeper look as it's not the only place where duplicates were filtered out by name.

filterCompatiblePatterns( pattern )
)
.map( ( pattern ) => ( {
...pattern,
Expand Down