Small tweaks to CreatePatternModal #56016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +8 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 60f600d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6817881975
|
jasmussen
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Nice one. Correct sizes, and avoiding the widow. Green check for that.
A couple of additional notes: I could've sworn that the categories field looked taller than the name field, but it's a visual illusion, they are both correctly 40px:
I wonder if it's the fact that there's placeholder text in one ("My pattern") but not the other. I'm assuming we can't show placeholder text in the specialized categories field, but I wonder, is it actually helpful to show placeholder text in the Name field? Could we do without it for a clearer initial view?
By the way, nice work on getting the focus styles right for the categories dropdown, I have a feeling that's also you, in some separate PR:
Can we get the buttons to also be 40px tall while we're here? Same general heuristic applies for the buttons as for inputs, 40px tall unless the context asks for compact 32:
It's probably helpful, but not as-is. Could be interesting to have examples of what you'd name a pattern, like "Main hero area" or something. |
Sure thing. |
richtabor
force-pushed
the
tweak/create-pattern-modal
branch
from
60f600d
to
363bf09
Compare
|
Updated with __next40pxDefaultSize on the buttons in the modal.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Should be very little visual changes.
__next40pxDefaultSizeinstead.Testing Instructions
Screenshots or screencast