Global Styles: Don't show "Apply Styles Globally" button in non-block based themes #56033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +22 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
This change makes sense to me, thanks for putting it forward. Could you recommend a hybrid theme to test it with? (with link) |
|
Ah never mind, I followed the tip over on the issue. |
ramonjd
approved these changes
Nov 12, 2023
aaronrobertshaw
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Thanks for the fix @t-hamano 👍
✅ Could replicate issue on trunk
✅ Block themes still have the "Apply styles globally" button
✅ Classic/hybrid themes with add_theme_support( 'block-template-parts' ) no longer show the button
Not sure if it's the naive way in which I tested (I just added add_theme_support( 'block-template-parts' ); to a classic theme) but this change also avoids a store error that tries to resolve dirty state in the editor:
I might have been missing something obvious but I could only trigger this error when attempting to use the "apply styles globally" button on a non-block theme.
|
Thanks for the review, @ramonjd, @aaronrobertshaw!
Sorry, I was expecting that you could access Anyway, I would like to merge this PR👍 |
|
Thanks everyone. Looks great! |
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56007
What?
This PR will prevent the "Apply Styles Globally" button from being displayed in hybrid themes that support block template parts.
Why?
This is because non-block-based themes do not support global styles UI and there is no way to reset global styles once applied.
How?
Checks if the current theme is a block theme when the button is rendered.
Testing Instructions
http://localhost:8888/wp-admin.