Fix flaky 'Meta boxes' e2e tests #56083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
The odd thing is that the original test passes for me locally, even when titles aren't in order. Update: The test was passing for me locally due to the locator scope, which also matched the "Latest Post" block in the widget, producing the following text contents: The Screenshot
|
Mamaduka
commented
Nov 13, 2023
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
I'm going to merge this as this fixes potential flaky tests and CI checks passed a few times on this PR. |
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Fix flaky 'Meta boxes' e2e tests * Just swap the expected text order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes flaky
Should render dynamic blocks when the meta box uses the excerpt for front end renderinge2e tests.Props to @noahtallen for spotting the issue - #55915 (comment).
How?
Updates assertion to sort post titles. The test doesn't care about the order, only that titles are rendered.Update the locator scope to only match the Latest Post list in the content and swap the order of the post items.
Testing Instructions