DataViews: fix nested button tags on sidebar. #56089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +84 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/nested-button-tags-on-dataviews
branch
from
f34f834
to
9c85aab
Compare
|
Thanks for handling this Jorge! This made me wonder though if we should have some |
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue noticed by @ntsekouras on #55924 (review). The markup we produced contained a nested button tag, additionally, when we clicked the DropDown it also triggered the click event in the list item. Both issues are fixed in this PR.
Testing