Block Quick Navigation: truncate text #56142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Block Locking
|
👍 👍 seems like a good solution. Happy to provide a green check but it seems it would be good to have a quick dev double-check too. |
|
Size Change: +20 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Thanks for the review, @jasmussen, @Mamaduka! |
|
This PR missed the required |
|
@oandregal Thank you, I didn't know that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR solves the following two problems that occur when the button text of the
BlockQuickNavigationcomponent is long.For example, this is the list displayed in the sidebar content panel when
templateLockmode iscontentOnly. For heading blocks, this problem is easier to reproduce because the text is displayed instead of the block name.How?
Similar to the list view, I prevent text wrapping through the
Truncatecomponent. At the same time, I restructured the button contents withFlex/FlexBlock/FlexItemso that the icon width is the same regardless of the text length.The only concern was that I needed some CSS to left-align the button text. This component doesn't have a stylesheet, so I added inline styles.
Testing Instructions
Paste the markup below into your code editor. This markup has a heading block with long text in a group that has
templateLock:contentOnlyset.