DataViews: update 'View' button #56144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +323 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jameskoster
added
[Type] Enhancement
ntsekouras
approved these changes
Nov 16, 2023
oandregal
changed the title
oandregal
added
[Type] Experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the appearance and behavior of the 'View' button in data views to match the designs. The current version appends a chevron that isn't necessary, and the icon is static. It's also too large compared with other buttons in the row.
Before
After
view.button.mp4
compactsizeTesting Instructions
Notes
gutenberg/packages/edit-site/src/components/sidebar-dataviews/dataview-item.js
Line 21 in 1bf654b