Unify the PageUrl and PageSlug components between site and post editors #56203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
jameskoster,
SaxonF,
jasmussen,
glendaviesnz and
ntsekouras
youknowriad
commented
Nov 16, 2023
| // Match padding on tertiary buttons for alignment. | ||
| padding: $grid-unit-15 * 0.5 0; | ||
| width: 30%; | ||
| margin-right: 8px; |
There was a problem hiding this comment.
These changes can feel random but they are changes meant to unify the spacing and the proportions of these panels between site and post editors.
As I move more panels into the editor package, I'll try to use a dedicated UI component that I'll be sharing between all these panels to avoid recreating the same design over and over again.
There was a problem hiding this comment.
You can use $grid-unit-10 instead of 8px.
There was a problem hiding this comment.
To be honest I'll just keep it as is for now as it's a bit random but I'm going to do better in the next PR I promise :P
youknowriad
commented
Nov 16, 2023
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import PageStatus from './page-status'; | ||
| import PublishDate from './publish-date'; | ||
| import EditTemplate from './edit-template'; | ||
| import PageSlug from './page-slug'; | ||
|
|
||
| export default function PageSummary( { |
There was a problem hiding this comment.
Slowly (panel by panel), I'm hoping to unify this component entirely between post and site editors.
|
Size Change: -357 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I have a slight preference for the simpler popover;
If we want to keep the same content, let's tidy it up a bit? 
|
|
I don't mind what updates we make to the UI itself, I just think it should be the same. I'm happy to follow-up. Only remark from the screenshot is that I do think that the URL should be visible to be easily copied (or have a copy button) |
100%. I'll open an issue to discuss the design when I find a minute. Definitely not a high-prio item :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Follow-up to #56000
What?
Now that we're using the EditorProvider in the site editor, we should be able to reuse the exact same component the post editor uses to edit post properties and attributes. In this PR, I'm unifying the "PostURL" or "PostSlug" component between both.
Note This PR also includes a small CSS notifications between site and post editors: now all the page summary details are 30% of the label and 70% for the actual control, in the post editor, it used to be 45% for the label.
Testing Instructions
1- Ensure that the changing the page slug/url date still looks and works well in both post and site editors.