Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for disableLineBreaks property of RichText #56284

Merged
merged 2 commits into from Apr 18, 2024

Conversation

ixkaito
Copy link
Contributor

@ixkaito ixkaito commented Nov 18, 2023

What?

Add documentation for disableLineBreaks property of RichText.

Why?

To improve the developer experience.

How?

Enhance documentation.

@torounit torounit added [Type] Developer Documentation Documentation for developers [Package] Block editor /packages/block-editor labels Nov 18, 2023
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @ixkaito!

I left a minor suggestion. Can you also rebase the branch on top of the current trunk? That should fix the failing CI checks.

packages/block-editor/src/components/rich-text/README.md Outdated Show resolved Hide resolved
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ixkaito <ixkaito@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka merged commit abf1b2c into WordPress:trunk Apr 18, 2024
58 checks passed
@Mamaduka
Copy link
Member

Thank you, @ixkaito!

@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 18, 2024
@ixkaito
Copy link
Contributor Author

ixkaito commented Apr 18, 2024

@Mamaduka Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants