Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update wording in Block Editor Handbook to reflect that all examples now use JSX #56315

Merged
merged 1 commit into from Apr 17, 2024

Conversation

atachibana
Copy link
Contributor

What?

PR #56121 removed the vanilla JS example pragrams and {% codetabs %} instances. However, references to these examples remain in the content body.

This PR removes and/or modifies them. It also addresses the PR #56121's forgetting to remove them.
cc: @ryanwelcher @juanmaguitar

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@juanmaguitar
Copy link
Contributor

LGTM! ✅
Thanks a lot @atachibana for this PR!

@DAreRodz DAreRodz added the [Type] Developer Documentation Documentation for developers label Nov 20, 2023
@atachibana atachibana changed the title Remove vanilla JS examples description. Docs: Remove vanilla JS examples description. Nov 29, 2023
@t-hamano
Copy link
Contributor

@atachibana Sorry for the late review. Could you please rebase this PR and resolve the conflict?

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: atachibana <atachibana@git.wordpress.org>
Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@atachibana
Copy link
Contributor Author

@t-hamano
Sorry for late response. It seems to be passed all checks at all.

@t-hamano
Copy link
Contributor

@atachibana Thanks for the update!

@t-hamano
Copy link
Contributor

In the end, this PR landed on minor wording corrections and the removal of unnecessary code tabs? If so, I would appreciate it if you could update the PR title to reflect the actual changes 🙏

@fabiankaegy fabiankaegy changed the title Docs: Remove vanilla JS examples description. Docs: Update wording in Block Editor Handbook to reflect that all examples now use JSX Apr 17, 2024
@fabiankaegy fabiankaegy merged commit fb4d29d into WordPress:trunk Apr 17, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants