Additional CSS: fix on change validation #56434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaguiini
added
the
Global Styles
|
Size Change: +3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
zaguiini
changed the title
zaguiini
deleted the
fix/use-new-value-style-transformation-advanced-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Let's pass the new value instead of the old one when re-running style checking in the advanced panel.
In #56093, I caught this error where when you input invalid CSS, blur the input, and change it, the OLD value is being passed to validate the CSS error tooltip.
Not only it's passing the old value, it's passing in the wrong format, breaking the
transformStylescall: instead of just the CSS string, we were passing the nested object which includescssas a property.Why?
With this patch, the CSS error badge is gone as soon as the user fixes the problem (on change) instead of only removing the error once they blur.
Screen.Recording.2023-11-22.at.13.01.28.mov
Screen.Recording.2023-11-22.at.13.04.42.mov
How?
We should pass the new value instead of the current one, and the string instead of an object with the css property.
Testing Instructions
On
trunk(after #56093 has been merged; use that as a starting point otherwise)body { background: red }) to it, making it valid CSSApply this PR to your environment and repeat the same steps, but verify that once the CSS is right, the error badge is gone, even when the user is still typing.