Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: document view.layout #56637

Merged
merged 3 commits into from Nov 29, 2023
Merged

DataViews: document view.layout #56637

merged 3 commits into from Nov 29, 2023

Conversation

oandregal
Copy link
Member

Part of #55083

Documents the view.layout prop, and all existing use cases (view.layout.grid and its props mediaField and primaryField).

@oandregal oandregal self-assigned this Nov 29, 2023
@oandregal oandregal added [Type] Experimental Experimental feature or API. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 29, 2023
youknowriad
youknowriad approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I wonder if at some point we'd have a section of the documentation about each layout in which case, they would move there.

@oandregal oandregal enabled auto-merge (squash) November 29, 2023 13:47
@oandregal oandregal merged commit c09075f into trunk Nov 29, 2023
51 checks passed
@oandregal oandregal deleted the add/docs-for-view-layout branch November 29, 2023 14:11
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 29, 2023
derekblank pushed a commit that referenced this pull request Dec 7, 2023
@oandregal @derekblank
DataViews: document view.layout (#56637)
63a792e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ntsekouras ntsekouras Awaiting requested review from ntsekouras

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees

@oandregal oandregal

Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Experimental Experimental feature or API.
Projects
None yet
Milestone
Gutenberg 17.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oandregal @youknowriad