Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label of columns inspector panel #56647

Merged
merged 1 commit into from Nov 29, 2023
Merged

Fix label of columns inspector panel #56647

merged 1 commit into from Nov 29, 2023

Conversation

megane9988
Copy link
Contributor

What?

#56461

Why?

Increase copy consistency.

How?

I also changed the copy for a native app.
How do you think about it?

Testing Instructions

  1. Go to the edit post page.
  2. Add column block.
  3. Check the panel.

Screenshots or screencast

image

@t-hamano t-hamano added [Type] Copy Issues or PRs that need copy editing assistance [Block] Columns Affects the Columns Block labels Nov 29, 2023
@t-hamano t-hamano self-requested a review November 29, 2023 14:34
t-hamano
t-hamano approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fluiddot @geriux Could you please confirm if this change also makes sense for the mobile app?

@fluiddot
Copy link
Contributor

fluiddot commented Nov 29, 2023 •
edited

LGTM 👍

@fluiddot @geriux Could you please confirm if this change also makes sense for the mobile app?

Yeah, I checked the app and the change looks good. Thanks for the call out 🙇 !

Before After

@t-hamano
Copy link
Contributor

Thanks for the review, @fluiddot!

@megane9988
Copy link
Contributor Author

@t-hamano @fluiddot Thanks for your fantastic reviews!

@t-hamano t-hamano merged commit ae430fe into WordPress:trunk Nov 29, 2023
54 of 55 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 29, 2023
@t-hamano t-hamano mentioned this pull request Nov 29, 2023
Closed
@richtabor
Copy link
Member

Very nice.

derekblank pushed a commit that referenced this pull request Dec 7, 2023
@megane9988 @derekblank
Fix label of columns inspector panel (#56647)
8679870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Columns Affects the Columns Block [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
Gutenberg 17.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@megane9988 @fluiddot @t-hamano @richtabor