Increase right padding of URL field to take the Submit button into account #56685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Thanks for this PR 🙇 I'll look to review early next week. |
getdave
force-pushed
the
fix/link-control-url-field-long-urls
branch
from
caabcde
to
9f09ca5
Compare
|
Reviewing now. I hope you don't mind but I rebased the PR to make it easier to test. |
getdave
force-pushed
the
fix/link-control-url-field-long-urls
branch
from
9f09ca5
to
2dc9aa5
Compare
getdave
approved these changes
Dec 6, 2023
|
Flaky tests detected in 2dc9aa5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7112852403
|
|
Nice catch. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56591
What?
In the link control URL field, long URLs show behind the Submit button.
Why?
The link control URL should always be fully displayed and not show behind the Submit button.
How?
Increases the right padding of the URL field by making it the same as the button width
Testing Instructions
http://localhost:8889/title-should-not-overflow-the-content-area/https://my-awesome-site.org/this-is-a-very-long-url-to-test-the-link-input-fieldTesting Instructions for Keyboard
Screenshots or screencast
Before:
After: