Fix top position and height of Pattern Modal Sidebar #56787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -50 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b8d2e9f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7102476215
|
t-hamano
force-pushed
the
fix/patterns-modal-sidebar-layout
branch
from
59647a9
to
b8d2e9f
Compare
t-hamano
commented
Dec 5, 2023
Comment on lines
-277
to
-279
| .block-editor-block-patterns__source-filter select.components-select-control__input { | ||
| height: 40px; | ||
| } |
There was a problem hiding this comment.
I searched the whole project for the keyword source-filter, but there doesn't seem to be any element with a class name containing that keyword. It existed in the past, but I don't think it exists now.
t-hamano
commented
Dec 5, 2023
| .block-editor-inserter__block-patterns-tabs-container, | ||
| .block-editor-block-patterns-explorer__sidebar { | ||
| .block-editor-inserter__block-patterns-tabs-container { |
There was a problem hiding this comment.
This change will also remove the following selector.
.block-editor-block-patterns-explorer__sidebar nav {
height:100%;
}However, it seems that there are no elements matching this selector.
t-hamano
added
[Type] Bug
jameskoster
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fix for #56740
What?
This PR fixes the following two issues in the Pattern Modal Sidebar.
Why?
I suspected that #51829, which added 4px padding to the top of the modal content, was the cause, but it doesn't seem to be the direct cause.
This might have been a pre-existing problem, or some change may have caused this problem.
This sidebar (
.block-editor-block-patterns-explorer__sidebar) is absolutely positioned, withbottom: 0applied. However, sinceheight:100%is also applied at the same time, the height will protrude.How?
I moved the top position of the sidebar up 4px.
I removed the unused code at the same time as the affecting code.
Testing Instructions
Screenshots or screencast
c38f63fecf28d186736622722e1d323c.mp4