Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification of labels in global style settings to singular form #56821

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

megane9988
Copy link
Contributor

What?

#56733
To resolve mixed plural and singular forms in global styling setting's labels.

Why?

I felt uncomfortable with the mixing of plural and singular forms.

How?

I have unified it into singular form.

Testing Instructions

  1. Dashboard → Appearance → Editor
  2. Styles → Edit styles(Pencil Icon)
  3. Typography or Colors from right panel
  4. Visually check that each label is unified into a singular form and that plural forms are not mixed.

Testing Instructions for Keyboard

Screenshots or screencast

image
image

image

@t-hamano t-hamano added [Type] Copy Issues or PRs that need copy editing assistance Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 6, 2023
@ramonjd ramonjd added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Mar 7, 2024
@kristastevens
Copy link

Hi 👋 Thanks for the copy review ping. This looks fine!

Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @kristastevens.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: kristastevens.

Co-authored-by: megane9988 <megane9988@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@kristastevens
Copy link

Hello!

Can we have the "Needs copy review" label removed? This PR pops up in our notifications each day. Thanks!

@torounit torounit removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Styles: Singular and plural forms are not consistent in the Color and Typography panel
5 participants