Zoomed out mode: show content container children #56890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Size Change: +113 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Dec 8, 2023
| @@ -290,6 +290,7 @@ function BlockSelectionButton( { clientId, rootClientId } ) { | |||
| <BlockTitle | |||
| clientId={ clientId } | |||
| maximumLength={ 35 } | |||
| context="list-view" | |||
There was a problem hiding this comment.
I don't think this will do anything since the BlockSelectionButton is no longer used in zoomed out mode since #56808
| @@ -105,12 +105,17 @@ function ListViewBranch( props ) { | |||
| const parentBlockInformation = useBlockDisplayInformation( parentId ); | |||
| const syncedBranch = isSyncedBranch || !! parentBlockInformation?.isSynced; | |||
|
|
|||
| const canParentExpand = useSelect( | |||
| const { canParentExpand, getBlockById } = useSelect( | |||
There was a problem hiding this comment.
List View also can't be accessed in zoomed out mode now, so the changes here might also not be needed
talldan
merged commit 3522b1a
into
try/zoomed-out-mode-experiments
58 of 59 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Shows the children of the
mainsection in the list view, and allows selection of these in editor canvas when in zoomed out mode.Why?
Currently it is not very easy to work with the body content in zoomed out view as it just appears as one big section.
How?
Detects a top level group container with tag of
mainand removes the editor overlay of it and shows direct children of this in the list view.Testing Instructions
mainto the top level body content groupScreenshots or screencast
content-sections.mp4