Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: combine store subscriptions #56994

Merged
merged 10 commits into from Dec 13, 2023
Merged

Block: combine store subscriptions #56994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d8c00b8
Block: combine store subscriptions
ellatrix Dec 12, 2023
066cea0
merge refs
ellatrix Dec 12, 2023
8aaf7ea
Fix order
ellatrix Dec 13, 2023
5176ce2
Fix html view
ellatrix Dec 13, 2023
735151f
debug error
ellatrix Dec 13, 2023
97cda3c
Try without warning
ellatrix Dec 13, 2023
f538213
Clean up
ellatrix Dec 13, 2023
4d813f5
minimize diff
ellatrix Dec 13, 2023
3945c0d
Add comments
ellatrix Dec 13, 2023
3e3d83a
Remove old comment
ellatrix Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/block-editor/src/components/block-editing-mode/index.js
View file
Open in desktop
Expand Up @@ -2,13 +2,13 @@
* WordPress dependencies
*/
import { useSelect, useDispatch } from '@wordpress/data';
import { useContext, useEffect } from '@wordpress/element';
import { useEffect } from '@wordpress/element';

/**
* Internal dependencies
*/
import { store as blockEditorStore } from '../../store';
import { BlockListBlockContext } from '../block-list/block-list-block-context';
import { useBlockEditContext } from '../block-edit/context';

/**
* @typedef {'disabled'|'contentOnly'|'default'} BlockEditingMode
Expand Down Expand Up @@ -45,7 +45,7 @@ import { BlockListBlockContext } from '../block-list/block-list-block-context';
* @return {BlockEditingMode} The current editing mode.
*/
export function useBlockEditingMode( mode ) {
const { clientId = '' } = useContext( BlockListBlockContext ) ?? {};
const { clientId = '' } = useBlockEditContext();
const blockEditingMode = useSelect(
( select ) =>
select( blockEditorStore ).getBlockEditingMode( clientId ),
Expand Down