Disable resizing when viewport is small and wide-aligned #57041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -4 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
artemiomorales and
michalczaplinski
as code owners
|
Flaky tests detected in 6784d47. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7204515681
|
aaronrobertshaw
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
LGTM also 👍
✅ Could replicate original issue
✅ Applying this PR's fix resolves the problem
I really appreciate the detailed issue laying out the history behind this regression. Thank you @t-hamano 🙇
|
Thanks for the review, @michalczaplinski, @aaronrobertshaw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #57003
What?
This PR fixes an issue where images can be resized unintentionally when the following conditions are met:
Why?
From what I've researched, this issue appears to be a regression that occurred when the gallery block was refactored to v2. More detailed information is provided in #57003.
How?
I change part of the conditional statement that determines whether it is resizable as follows. I believe this is the expected condition.
Testing Instructions