e2e: Try to fix flaky font-library test #57092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
t-hamano
added
[Type] Automated Testing
|
The Playwright tests, which include this test, have never failed and appear to be stable. |
t-hamano
force-pushed
the
fix/e2e-font-library
branch
from
411027e
to
7e9731f
Compare
|
Thanks for the review, @Mamaduka! I've rebased this branch with the latest trunk. I would like to merge once the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Attempt to fix Flaky test reported in #56776
Why?
This e2e test seems to be unstable. I checked Artifacts and it seems that neither the sidebar nor the canvas is loading correctly.
How?
This test concerns the global style panel, so it doesn't matter which template is opened. Therefore, I am trying to remove the
visitSiteEditor()argument and see if the test becomes stable.Testing Instructions
Try running the e2e test multiple times.