Enforce heading sentence case throughout the BEH #57143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiego
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Flaky tests detected in ce674db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7241631320
|
t-hamano
reviewed
Dec 18, 2023
There was a problem hiding this comment.
These changes make sense to me too, but I'd like to leave a comment with some typo corrections or suggestions.
Also, in the document style guide, there is a rule called "Always capitalize proper nouns.".
For example, which rule do you think should be followed in this PR?
- Block supports or Block Supports?
- Global styles of Global Styles?
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
Thanks for reviewing @t-hamano and fixing my typos 🤦♂️ |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Enforce heading sentence case. * Linting * Update title and remove unnecessary TOC * Update docs/how-to-guides/README.md Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update docs/reference-guides/richtext.md Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update docs/explanations/user-interface/block-design.md Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Update docs/how-to-guides/internationalization.md Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not exhaustive, but it is a first step in enforcing sentence case for all headings throughout the Block Editor Handbook. This is in accordance with the documentation style guide.
Edit: While updating the Explanations → Architecture → Styles in the Editor doc, I also took the liberty of removing the unnecessary TOC and fixing the heading hierarchy. I missed this in #57087