InserterListItem: use item.isDisabled to detect disabled item #57161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
This makes sense thanks for the fix.
For the suggestion about creating the "blocks" only on drag. It is indeed something that would be a perf optimization but I'm afraid that we're basically removing all (almost) the value of the Draggable component. So it seems we might want to rethink that component's API.
|
Maybe all we need is the And in the case of synced patterns, it's currently being overridden dynamically in a somewhat hacky way: A |
|
@jsnajdr That seems like a reasonable path yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a little bug I noticed when working on block lazy loading. When
InserterListItemdecides whether the item should be draggable or not, it looks atitem.disabled, but the real name of the field isitem.isDisabled! You can see for yourself in functions likegetInserterItemsorbuildBlockTypeItemthat build theseitemobjects.Another fix is correct dependencies in
useMemohook that creates the blocks to insert by the drag&drop. TheinnerBlocksdependency was missing. These data also come frombuildBlockTypeItem, and their ultimate source is the block registration info and the registered variations. They should be constants.The
createBlockscall leads me to another idea: as a followup, we should optimizeInserterListItemandInserterDraggableBlocksto create the blocks only when we really start the drag&drop process. On the vast majority of inserter render drag&drop is not used, so the blocks are created too eagerly.Also, if drag&drop is disabled, like it always is in the Quick Inserter, we don't need to render
InserterDraggableBlocksat all, it acts as a pass-through noop anyway. Let's render theInserterListboxItemdirectly.WDYT?