useBlockTypesState: divide useSelect call into two #57163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Dec 18, 2023
Comment on lines
+26
to
+29
| const [ items ] = useSelect( | ||
| ( select ) => [ | ||
| select( blockEditorStore ).getInserterItems( rootClientId ), | ||
| ], |
There was a problem hiding this comment.
Nit: I think we can just return items here as we're dealing with a single collection now.
There was a problem hiding this comment.
Then useSelect would shallow compare all the elements on each call, and that's wasted time when it can just compare oldItems === newItems once, on the memoized array.
There was a problem hiding this comment.
I thought it would bail out early if oldItems === newItems and avoid shallow comparison.
There was a problem hiding this comment.
I thought it would bail out early if
oldItems === newItemsand avoid shallow comparison.
@Mamaduka you're right! @wordpress/is-shallow-equal really does a === comparison first and returns early.
But I think I'll keep the [ items ] form anyway, for the sake of consistency 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little optimization, or maybe just dividing one complex functions into two simpler ones. The
categoriesandcollectionsare constants, they don't change whenrootClientIdchanges or whenblock-editorstore is updated. Avoid calling thegetCategories/Collectionsselectors when not needed.