Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperlink to media-upload documentation #57170

Merged
merged 2 commits into from Feb 27, 2024
Merged

Conversation

bacoords
Copy link
Contributor

What?

While the link to the media-upload readme file works on GitHub, in the Block Editor handbook it doesn't render as a link: https://developer.wordpress.org/block-editor/reference-guides/packages/packages-media-utils/

Screenshots or screencast

Current screenshot of the handbook:
Screenshot 2023-12-18 at 7 48 34 AM

@bacoords
Copy link
Contributor Author

@ndiego Can you check this and maybe tag it Developer Documentation if you think it makes sense?

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Dec 20, 2023
@ndiego ndiego enabled auto-merge (squash) December 20, 2023 16:31
@ndiego ndiego self-requested a review December 20, 2023 16:31
@ndiego
Copy link
Member

ndiego commented Dec 20, 2023

Thanks Brian, I just approved and restarted the failed test.

@Mamaduka
Copy link
Member

Hi, @bacoords

Can you rebase the branch on top of the latest trunk? That should resolve CI failures.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: bacoords <bacoords@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ndiego ndiego merged commit 6d7ae45 into WordPress:trunk Feb 27, 2024
54 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants