Editor: Unify the list view shortcut registration and definition #57200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: -420 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
commented
Dec 19, 2023
| screen.getByRole( 'dialog', { | ||
| name: 'Keyboard shortcuts', | ||
| } ) | ||
| ).toMatchSnapshot(); |
There was a problem hiding this comment.
This is a useless test (we just update the snapshot when it changes)
youknowriad
force-pushed
the
unify/list-view-shortcut
branch
from
4690981
to
3984e1c
Compare
|
I think the Opportunity for more unification 😄 |
There was a problem hiding this comment.
I think the edit-site package doesn't register global shortcuts from the editor package (EditorKeyboardShortcuts); this is the reason e2e tests are failing.
Thanks @Mamaduka, that makes sense! And it's consistent with manual testing (CTRL+Option+o opens the list view in the post editor but not the site editor for me with this PR applied).
|
Flaky tests detected in 6c8e4cb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7273491562
|
ellatrix
reviewed
Dec 20, 2023
| @@ -101,16 +99,6 @@ function KeyboardShortcuts() { | |||
| }, | |||
| } ); | |||
|
|
|||
| registerShortcut( { | |||
| name: 'core/edit-post/toggle-list-view', | |||
There was a problem hiding this comment.
I guess unregistering this won't work anymore? Anyway, I think that's fine :)
bph
added
the
[Feature] List View
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This is a small refactor to unify the list view keyboard shortcut definition between the site and post editors, since now the state has moved to the editor package.
Testing Instructions
1- You can open and close the list view using the shortcut