Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Links: add Bluesky logo #57277

Closed
wants to merge 6 commits into from
Closed

Conversation

jeherve
Copy link
Contributor

@jeherve jeherve commented Dec 20, 2023

What?

This introduces a new Social Link icon, for the Bluesky service. The icon was made official a few months ago, in this post.

Why?

Bluesky, despite being a fairly new addition to the social network scene, has quickly become quite popular as an alternative to Twitter. It could be useful for site owners to want to list their Bluesky profile alongside their other social media presences.

How?

This adds the new icon and service, as well as tests.

Testing Instructions

  1. Go to Posts > Add New
  2. Add the Social Links block
  3. Within the block, add a new Bluesky block
  4. Publish your post
  5. View on the frontend.

Testing Instructions for Keyboard

Same as above, this behavior does not change in this PR.

Screenshots or screencast

Screenshot 2023-12-20 at 17 58 28 Screenshot 2023-12-20 at 17 57 37

Copy link

github-actions bot commented Dec 20, 2023

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Block] Social.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@Krisueu
Copy link

Krisueu commented Jan 26, 2024

Unfortunately the test does not work

The bluesky button is now available for download from the official website

https://blueskyweb.xyz/blog/press-faq

Here is the link : https://drive.google.com/drive/folders/16mlJPfWNnc6jj-3vGZ88SFysIY13GBp0

@jeherve
Copy link
Contributor Author

jeherve commented Jan 29, 2024

Unfortunately the test does not work

I believe you're referring to the "Enforce labels on Pull Request" test? This can only be addressed by folks who have admin access on this repository, I'm afraid, so we'll need to wait until they review this Pull Request.

The bluesky button is now available for download from the official website

Yes, that's the logo used on this Pull Request.

@electricbrick
Copy link

There's a duplicate issue over at Automattic/wp-calypso#87249 (comment) — I don't know if Gutenberg adding the icon would negate the Calypso issue or not.

Regardless, since Bluesky is officially open for all, it would make sense to prioritize the addition of their icon in an upcoming release.

Copy link

github-actions bot commented Feb 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jeherve <jeherve@git.wordpress.org>
Co-authored-by: Krisueu <krisueu@git.wordpress.org>
Co-authored-by: electricbrick <hifidesign@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@skorasaurus skorasaurus added the [Block] Social Affects the Social Block - used to display Social Media accounts label Feb 22, 2024
@electricbrick
Copy link

@ajitbohra seems this merge is being held up by an issue that has no bearing on the icon itself.

@jeherve
Copy link
Contributor Author

jeherve commented May 20, 2024

Looks like #61372 was open and merged, so this is now unnecessary. I'll close it.

@jeherve jeherve closed this May 20, 2024
@jeherve jeherve deleted the add/bluesky-icon branch May 20, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants