Global styles revisions: refactor sticky pagination footer to use CSS #57294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now delete the Slot Container, which is not used elsewhere.
ramonjd
added
[Type] Code Quality
|
Size Change: -151 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Just double-checking while testing, but it looks like the screengrabs in the PR description are the wrong way around? (I.e. the screengrab for Trunk is actually the screengrab for this PR?) |
|
Flaky tests detected in a0fa769. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7283379749
|
andrewserong
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Tests well for me across Chrome, Safari, FF, and Edge!
Because the footer now sits within a scrollable container, the width of the pagination will be affected by the browser's scrollbar. See the screencasts below. So, one option is to forget about this PR.
I actually don't mind it. It only really affects the final page of the results, and only in browser windows short enough for a scrollbar to be present, so doesn't sound like a blocker to me. But I'm not a designer!
I think overall, going with a CSS approach keeps things simpler, which seems worthwhile to me in this case. LGTM ✨
|
Thanks @andrewserong! |
You are right. Good quality control! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow up to:
Let's fix the pagination to the bottom of the sidebar panel using CSS.
We can now delete the Slot Container, which is not used elsewhere.
Warning
Because the footer now sits within a scrollable container, the width of the pagination will be affected by the browser's scrollbar. See the screencasts below. So, one option is to forget about this PR.
Why?
CSS.
How?
Making the footer sticky.
And relying on the convenient fact that
.edit-site-global-styles-sidebar__navigator-screenhas adisplay: flexrule.Testing Instructions
Open up the site editor, ensuring you have plenty of Global styles revisions (more than 10 to enable pagination).
Check that the pagination:
Screenshots or screencast
Trunk
2023-12-21.13.34.50.mp4
This PR
2023-12-21.13.33.17.mp4